New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass allItems
and currentItems
to _pagination.paginate()
#1100
Merged
Merged
Changes from 23 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
59a2ea1
feat: pass allItems and currentItems to paginate
jaulz 791f297
fix: add currentItems to filter
jaulz 1186829
fix: add currentItems to shouldContinue
jaulz d1d521b
fix: add current to filter and shouldContinue
jaulz 4232b81
test: check if allItems and currentItems are arrays
a4b1a2b
style: fix lint
7b01010
fix: use t helper
jaulz bccd95e
fix: use t helper
jaulz de3c26e
test: fix test
3f29cc8
fix: remove typos
a7c5c69
docs: add currentItems to readme
68cc75a
fix: lint
7ebf342
docs: update readme
jaulz e1fa9bd
docs: fix readme
jaulz f60aaab
docs: update readme
jaulz 872e27b
docs: add example to readme
jaulz b21be19
docs: update readme
3d7959e
docs: use block
jaulz c31f2f9
Update readme.md
szmarczak 86d57b9
Update readme.md
szmarczak b10be23
Update readme.md
szmarczak 09c41c0
Update readme.md
szmarczak 8054ab1
Update create.ts
szmarczak e49dec2
Update test/pagination.ts
szmarczak 4f2e21a
Update readme.md
sindresorhus 9850542
docs: add full example to readme
jaulz badc8be
docs: add import and console.log to example
jaulz 68f0c42
Update readme.md
sindresorhus File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer the example to be fully runnable, meaning that it includes the import statement and
got(…)
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just extended the example.