[WIP] HTTP2 support #832
[WIP] HTTP2 support #832
Conversation
|
@sindresorhus Maybe let's make all the tests use a HTTP2 server instead of HTTP1? That way we would be sure that |
Ideally, we would run all tests on both a HTTP1 and HTTP2 server to ensure everything works in both modes. |
So... Use an environment variable? And then run AVA twice? |
| // @ts-ignore `cacheable-request` doesn't support async request function | ||
| result.once = emitter.once.bind(emitter); | ||
|
|
||
| // @ts-ignore This is a TS bug, because `result` is `Promise<http.ClientRequest>` |
There was a problem hiding this comment.
It complains that I have typed it badlyrequest is unknown
|
|
||
| // @ts-ignore This is a TS bug, because `result` is `Promise<http.ClientRequest>` | ||
| // eslint-disable-next-line promise/prefer-await-to-then | ||
| result.then((request: http.ClientRequest) => { |
There was a problem hiding this comment.
return result.then(...);
| @@ -218,12 +248,18 @@ export default (options: NormalizedOptions): RequestAsEventEmitter => { | |||
| } | |||
| }); | |||
|
|
|||
| cacheRequest.once('request', handleRequest); | |||
| cacheRequest.once('request', async (request: Promisable<http.ClientRequest>) => { | |||
There was a problem hiding this comment.
Promisable -> ClientRequest | Promise<ClientRequest>
Yeah |
|
Closing in favor of #1051 |
Fixes #167
Checklist