importing index.ts in readme.md deno example #499
Conversation
for deno I think it's better to use the more idiomatic index.ts export from https://deno.land
|
Did you test that this works? |
readme.md
Outdated
| @@ -110,7 +110,7 @@ console.log(json); | |||
| If you are using [Deno](https://github.com/denoland/deno), import Ky from a URL. For example, using a CDN: | |||
|
|
|||
| ```js | |||
| import ky from 'https://esm.sh/ky'; | |||
| import ky from "https://deno.land/x/ky/source/index.ts"; | |||
There was a problem hiding this comment.
Single-quotes
I would also prefer to keep the esm.sh example below the new Deno.land one.
There was a problem hiding this comment.
Did you test that this works?
😬 sorry about that! does the deno.land publish work at all? couldn't find a working path
There was a problem hiding this comment.
I don't know. I don't use Deno.
There was a problem hiding this comment.
ok thanks, it doesn't work.
There was a problem hiding this comment.
At some point, they changed the backend architecture of deno.land so that in order to publish new releases of Ky on there, we have to set up a webhook on our repository, whereas before they had some magic to watch for GitHub releases automatically.
We just need to set up this webhook and then importing from deno.land will work again.
single quotes
for deno I think it's better to use the more idiomatic index.ts export from https://deno.land