New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow input to start with slash by removing head slashes #561
base: main
Are you sure you want to change the base?
Allow input to start with slash by removing head slashes #561
Conversation
by replacing slashes at the start of the input
15ef69e
to
cb89702
Compare
package.json
Outdated
@@ -72,6 +72,7 @@ | |||
"raw-body": "^2.5.2", | |||
"tsx": "^4.7.0", | |||
"typescript": "^5.2.2", | |||
"undici-types": "^6.6.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is used here:
Line 1 in cb89702
import {type RequestInit as UndiciRequestInit} from 'undici-types'; |
I got a warning about the library not being found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the dependency since it is no needed from v1.2.2.
From the docs:
|
I see. Could it be something "discouraged", rather than something "disallowed"? From the little I saw, I don't see how this change could break things in the library. 🙈 |
input
param to start with slash (/
) by removing head slashes