Fix tests on Windows and Node.js 12 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanZim
force-pushed
the
fix-tests
branch
5 times, most recently
from
784e294
to
8655e0b
Compare
|
Tests still failing, due to |
sindresorhus
changed the title
sindresorhus
changed the title
|
Thanks :) |
|
I fixed the linting issue, but now it's throwing a different error: https://travis-ci.org/sindresorhus/make-dir/jobs/649422483#L74 |
|
@sindresorhus TravisCI is using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered when working on #19.
Seems Node 12 returns a different error code.