Add TypeScript definition #116
Merged
+262
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
requested changes
Mar 13, 2019
This was referenced Mar 13, 2019
|
|
Published :) |
| /** | ||
| Flags converted to camelCase excluding aliases. | ||
| */ | ||
| flags: {[name: string]: unknown}; |
There was a problem hiding this comment.
What your opinion on {[name: string]: unknown}; vs Record<string, unknown>?
There was a problem hiding this comment.
I think {[name: string]: unknown}; is more common, so I'd prefer this.
There was a problem hiding this comment.
And it allows naming the key.
sindresorhus
approved these changes
Mar 19, 2019
|
This looks great! :) |
|
Just FYI. It's probably going to take some time until I can publish this one as it's blocked by doing the next major release. |
tommy-mitchell
added a commit
to tommy-mitchell/meow
that referenced
this pull request
Jan 28, 2024
- this was introduced in sindresorhus#77, likely due to compatibility with minimist - `booleanDefault: null` causes minimist-options to error - even in 2019, this was a confusing type: sindresorhus#116 (comment)
tommy-mitchell
added a commit
to tommy-mitchell/meow
that referenced
this pull request
Feb 29, 2024
* this was introduced in sindresorhus#77, likely due to compatibility with minimist * `booleanDefault: null` causes minimist-options to error * even in 2019, this was a confusing type: sindresorhus#116 (comment)
tommy-mitchell
added a commit
to tommy-mitchell/meow
that referenced
this pull request
Feb 29, 2024
* this was introduced in sindresorhus#77, likely due to compatibility with minimist * `booleanDefault: null` causes minimist-options to error * even in 2019, this was a confusing type: sindresorhus#116 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.