Require Node.js 8, add TypeScript definition #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BendingBender
changed the title
BendingBender
changed the title
sindresorhus
requested changes
Mar 13, 2019
|
Can you mention in the readme that the returned promise is cancelable (and link to |
sindresorhus
approved these changes
Mar 14, 2019
|
@BendingBender Just wanted to say how incredible thankful I am for all your help with adding TS definitions and your high-quality work. 🙌👍🙏 |
|
You're welcome. Thank you for your great modules! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for:
Add TypeScript definition p-cancelable#16Require Node.js 8, add TypeScript definition p-some#9Fixes #3