Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isRequired flag option #141

Merged
merged 26 commits into from May 7, 2020
Merged

Add isRequired flag option #141

merged 26 commits into from May 7, 2020

Commits on Mar 24, 2020

  1. Add isRequired option for flags

    @sbencoding
    sbencoding committed Mar 24, 2020
    Copy the full SHA
    abd6b12 View commit details
    Browse the repository at this point in the history

  2. Add ability to specify isRequired as a function

    @sbencoding
    sbencoding committed Mar 24, 2020
    Copy the full SHA
    3d2f6c8 View commit details
    Browse the repository at this point in the history

  3. Add type definition for isRequired

    @sbencoding
    sbencoding committed Mar 24, 2020
    Copy the full SHA
    9b0c22a View commit details
    Browse the repository at this point in the history

  4. Sync readme with typedef comments and examples

    @sbencoding
    sbencoding committed Mar 24, 2020
    Copy the full SHA
    45fb69a View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2020

  1. Merge feature branch with upstream/master

    @sbencoding
    sbencoding committed Apr 28, 2020
    Copy the full SHA
    aebcf85 View commit details
    Browse the repository at this point in the history

  2. Use console.error, better variable naming

    @sbencoding
    sbencoding committed Apr 28, 2020
    Copy the full SHA
    6bde170 View commit details
    Browse the repository at this point in the history

  3. Update documentation

    @sbencoding
    sbencoding committed Apr 28, 2020
    Copy the full SHA
    c095990 View commit details
    Browse the repository at this point in the history

  4. Use stderr, because missing flags are printed with console.error

    @sbencoding
    sbencoding committed Apr 28, 2020
    Copy the full SHA
    1d9fa7d View commit details
    Browse the repository at this point in the history

  5. Split out isRequired logic to separate methods

    @sbencoding
    sbencoding committed Apr 28, 2020
    Copy the full SHA
    1f6423a View commit details
    Browse the repository at this point in the history

  6. Organize tests and fixtures, update affected paths

    @sbencoding
    sbencoding committed Apr 28, 2020
    Copy the full SHA
    a5c24a2 View commit details
    Browse the repository at this point in the history

  7. Split out isRequired flag related tests to separate file, better test… 

    … descriptions
    @sbencoding
    sbencoding committed Apr 28, 2020
    Copy the full SHA
    bf0d816 View commit details
    Browse the repository at this point in the history

  8. Specify fixture path better

    @sbencoding
    sbencoding committed Apr 28, 2020
    Copy the full SHA
    8b03f9f View commit details
    Browse the repository at this point in the history

  9. Add isRequired (as function) return value to documentation

    @sbencoding
    sbencoding committed Apr 28, 2020
    Copy the full SHA
    854e294 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2020

  1. Merge branch 'master' into feature-flag-is-required

    @sbencoding
    sbencoding committed May 6, 2020
    Copy the full SHA
    e25cfdc View commit details
    Browse the repository at this point in the history

  2. Fix broken state after merge

    @sbencoding
    sbencoding committed May 6, 2020
    Copy the full SHA
    c54437d View commit details
    Browse the repository at this point in the history

  3. Improve documentation

    @sbencoding
    sbencoding committed May 6, 2020
    Copy the full SHA
    80cc740 View commit details
    Browse the repository at this point in the history

  4. Simplify code, check isRequired callback return value type

    @sbencoding
    sbencoding committed May 6, 2020
    Copy the full SHA
    019dd32 View commit details
    Browse the repository at this point in the history

  5. Add test for isRequired callback return value validation

    @sbencoding
    sbencoding committed May 6, 2020
    Copy the full SHA
    940fb96 View commit details
    Browse the repository at this point in the history

  6. Add handling of isMultiple flags to the isRequired logic

    @sbencoding
    sbencoding committed May 6, 2020
    Copy the full SHA
    3c1c710 View commit details
    Browse the repository at this point in the history

  7. Add tests for isRequired and isMultiple options set at the same time

    @sbencoding
    sbencoding committed May 6, 2020
    Copy the full SHA
    22f0a77 View commit details
    Browse the repository at this point in the history

  8. Fix estest path

    @sbencoding
    sbencoding committed May 6, 2020
    Copy the full SHA
    e11a0ad View commit details
    Browse the repository at this point in the history

Commits on May 7, 2020

  1. Update index.d.ts

    @sindresorhus
    sindresorhus committed May 7, 2020
    Copy the full SHA
    e5dac8b View commit details
    Browse the repository at this point in the history

  2. Update readme.md

    @sindresorhus
    sindresorhus committed May 7, 2020
    Copy the full SHA
    1e04bdc View commit details
    Browse the repository at this point in the history

  3. Update fixture-required-function.js

    @sindresorhus
    sindresorhus committed May 7, 2020
    Copy the full SHA
    59de8b8 View commit details
    Browse the repository at this point in the history

  4. Update fixture-required-multiple.js

    @sindresorhus
    sindresorhus committed May 7, 2020
    Copy the full SHA
    3dee237 View commit details
    Browse the repository at this point in the history

  5. Update fixture-required.js

    @sindresorhus
    sindresorhus committed May 7, 2020
    Copy the full SHA
    4b7a7ac View commit details
    Browse the repository at this point in the history