Improve tests #255
Merged
Improve tests #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommy-mitchell
commented
Feb 28, 2024
Comment on lines
+23
to
+42
| test.todo('version'); | ||
|
|
||
| test('overriding pkg still normalizes', t => { | ||
| const cli = meow({ | ||
| importMeta, | ||
| pkg: { | ||
| name: 'browser-sync', | ||
| bin: './bin/browser-sync.js', | ||
| }, | ||
| }); | ||
|
|
||
| t.like(cli, { | ||
| pkg: { | ||
| name: 'browser-sync', | ||
| version: '', | ||
| }, | ||
| }); | ||
|
|
||
| // TODO: test that showVersion logs undefined | ||
| }); |
There was a problem hiding this comment.
I think these test cases can be added later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separating some test modernization out from #252. Need to do a once over to check everything but I'm pretty confident with this.
Tried renaming files to keep blame history, but not all of them made it through. Oh well.