Replace webpack with parcel #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
commented
Apr 6, 2021
| @@ -1,3 +1,4 @@ | |||
| import browser from 'webextension-polyfill'; | |||
There was a problem hiding this comment.
No longer globally-available; This is required until fregante/browser-extension-template#48 is resolved
| "sinon": "^7.3.2", | ||
| "sinon-chrome": "^3.0.1", | ||
| "size-plugin": "^1.2.0", | ||
| "stylelint": "^10.1.0", | ||
| "stylelint": "^13.12.0", |
There was a problem hiding this comment.
Update was required due to an @import bug
| }, | ||
| "stylelint": { | ||
| "extends": "stylelint-config-xo", | ||
| "rules": { | ||
| "declaration-no-important": null | ||
| } | ||
| }, | ||
| "webExt": { | ||
| "sourceDir": "distribution" |
There was a problem hiding this comment.
Extra: now you can run web-ext run in the root.
This reverts commit 6533bad.
|
The options page appears to work. Untested elsewhere because I'm notification zero 😌 |
|
Thanks for doing this. Seems to be working fine. |
|
🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to fix #251 but of course webpack’s config was a PITA to update and conform to ESM, so the next logical step was… fregante/browser-extension-template#44
To get started I ran: