Prevents package from crashing when import.meta.url is undefined #306
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents
open
from crashing when the package is bundled for non-ESM format.It does so by adding a simple truthy guard for
import.meta.url
before passing it tofileURLToPath()
function.In non-ESM context,
import.meta.url
isundefined
.open/index.js
Lines 13 to 15 in 36c61af
And since
fileURLToPath()
does not acceptundefined
value as argument, it will throw the following error: