Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow default as a spinner #175

Merged
merged 3 commits into from
Jun 8, 2021
Merged

Don't allow default as a spinner #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d00e898
fix(validation): don't allow 'default' as spinner
erezrokah Jun 7, 2021
19f6ee6
Update test.js
sindresorhus Jun 8, 2021
cb3d31c
Update test.js
sindresorhus Jun 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ class Ora {
} else if (spinner === undefined) {
// Set default spinner
this._spinner = cliSpinners.dots;
} else if (cliSpinners[spinner]) {
} else if (spinner !== 'default' && cliSpinners[spinner]) {
this._spinner = cliSpinners[spinner];
} else {
throw new Error(`There is no built-in spinner named '${spinner}'. See https://github.com/sindresorhus/cli-spinners/blob/main/spinners.json for a full list.`);
Expand Down
6 changes: 6 additions & 0 deletions test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,12 @@ if (process.platform !== 'win32') {
});
}

test('throw when spinner is set to `default`', t => {
t.throws(() => {
new Ora({spinner: 'default'}); // eslint-disable-line no-new
}, /no built-in spinner/);
});

test('indent option', t => {
const stream = getPassThroughStream();
stream.isTTY = true;
Expand Down