Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: osLocaleSync get wrong locale because of execSync returns undefined #52

Merged
merged 2 commits into from
Dec 23, 2021
Merged

fix: osLocaleSync get wrong locale because of execSync returns undefined #52

merged 2 commits into from
Dec 23, 2021

Conversation

MisterLuffy
Copy link
Contributor

Because the return value of execSync is a string, execSync().stdout will be undefined.

So, why not TypeScript? 馃檭

@sindresorhus
Copy link
Owner

So, why not TypeScript?

sindresorhus/ky#321 (comment)

@sindresorhus sindresorhus merged commit 4ea3039 into sindresorhus:main Dec 23, 2021
@sindresorhus
Copy link
Owner

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MisterLuffy @sindresorhus