Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Intl.Segmenter, require Node.js v16 #47

Merged
merged 7 commits into from May 5, 2023
Merged

Use Intl.Segmenter, require Node.js v16 #47

merged 7 commits into from May 5, 2023

Conversation

fisker
Copy link
Contributor

@fisker fisker commented May 5, 2023 •
edited

Fixes #35
Fixes #43

stringWidth('\u{845B}\u{E0100}')
// -> 3 (Before)
// -> 2 (After)

@fisker fisker mentioned this pull request May 5, 2023
Merged
@sindresorhus sindresorhus merged commit f85812f into sindresorhus:main May 5, 2023
3 checks passed
@fisker fisker deleted the segmenter branch May 5, 2023 15:31
@outloudvi outloudvi mentioned this pull request May 23, 2023
Closed
frantic1048 added a commit to frantic1048/Restia that referenced this pull request May 23, 2023
@frantic1048
Revert "fix(dependencies): update dependency string-width to v6"
450333d 
This reverts commit 39f56ba.

string-width@6 uses `Intl.Segment` while no Firefox version has implemented

- sindresorhus/string-width#47
- sindresorhus/string-width#50 (comment)
@frantic1048 frantic1048 mentioned this pull request May 23, 2023
Merged
frantic1048 added a commit to frantic1048/Restia that referenced this pull request May 23, 2023
@frantic1048
Revert "fix(dependencies): update dependency string-width to v6"
7a625b6 
This reverts commit 39f56ba.

string-width@6 uses `Intl.Segment` while no Firefox version has implemented

- sindresorhus/string-width#47
- sindresorhus/string-width#50 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

thai combining charactern not working Use Intl.Segmenter when available?
2 participants
@fisker @sindresorhus