Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove $ from trash-cli install command #127

Merged
merged 2 commits into from Oct 21, 2023

Conversation

BolajiAyodeji
Copy link
Contributor

@BolajiAyodeji BolajiAyodeji commented Oct 21, 2023

GitHub code snippets have a copy feature, as seen in the screenshot below, which I use often and believe others do.

Screenshot 2023-10-21 at 10 52 21

If the copied shell command includes the $ prefix, it will lead to an error when copied and pasted directly in the terminal like so:

Screenshot 2023-10-21 at 10 53 37

Users will now have to edit the copied text again or type manually, which is a bad experience and a waste of the copy-snippet feature, which is great for installing packages and so. Hence, this PR removes the $ prefix from the install trash-cli command. I believe this will remove the repetitive behaviour.

Thanks for creating this, Sindre!

@sindresorhus sindresorhus merged commit db55a36 into sindresorhus:main Oct 21, 2023
9 checks passed
@BolajiAyodeji BolajiAyodeji deleted the patch-1 branch October 21, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants