New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix `Join` edge case when type inference fails #314

Merged

sindresorhus merged 1 commit into sindresorhus:main from o-alexandrov:main

Nov 9, 2021

Contributor

o-alexandrov commented Nov 9, 2021

When adding support for numbers in #258 , I introduced a regression when TypeScript fails to infer the typings of the Join's first parameter.

This PR sets the default type of the Join's return to be string, not string | number


          Fix Join edge case when type inference fails

9340ae8

sindresorhus merged commit e0e202c into sindresorhus:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment