Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow all keys to be optional in the JsonObject type #65

Merged
merged 3 commits into from Feb 14, 2020
Merged

Allow all keys to be optional in the JsonObject type #65

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09aa477
fix(JsonObject): allow all keys to be optional
yxliang01 Oct 8, 2019
a870e29
fix(JsonObject): syntax error
yxliang01 Oct 8, 2019
9b3699d
fix.lint(JsonObject): type parameter
yxliang01 Oct 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/basic.d.ts
View file
Open in desktop
Expand Up @@ -40,7 +40,7 @@ Matches a JSON object.

This type can be useful to enforce some input to be JSON-compatible or as a super-type to be extended from. Don't use this as a direct return type as the user would have to double-cast it: `jsonObject as unknown as CustomResponse`. Instead, you could extend your CustomResponse type from it to ensure your type only uses JSON-compatible types: `interface CustomResponse extends JsonObject { … }`.
*/
export type JsonObject = {[key: string]: JsonValue};
export type JsonObject = {[Key in string]?: JsonValue};

/**
Matches a JSON array.
Expand Down