Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove bottom extra blank line in file panel #424

Closed
wants to merge 1 commit into from

Conversation

0x00-ketsu
Copy link

In Diffview panel, Press command G, it'is jump to bottom line, which is a empty line.

image

Copy link
Owner

@sindrets sindrets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're gonna change this, don't change logic in the renderer. The renderer should always render the data it's given, as is. You want to change the UI logic, around here:

@sindrets sindrets added the stale The issue or PR has grown stale due to inactivity label May 18, 2024
@sindrets
Copy link
Owner

Feel free to reopen if you wish to come back to this.

@sindrets sindrets closed this May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale The issue or PR has grown stale due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants