Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(git): add --no-exclude-standard when detecting binary #484

Merged
merged 2 commits into from
May 23, 2024

Conversation

Summon528
Copy link
Contributor

Otherwise, files that was included in gitignore (but added via git add --force) will be treated as binary and not showing diff.

Copy link
Owner

@sindrets sindrets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This change makes sense, just fix that one bug and I'll include this.

Co-authored-by: Sindre T. Strøm <sindrets@gmail.com>
@Summon528
Copy link
Contributor Author

Updated, thanks

Copy link
Owner

@sindrets sindrets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sindrets sindrets changed the title add --no-exclude-standard for detecting binary fix(git): add --no-exclude-standard when detecting binary May 23, 2024
@sindrets sindrets merged commit f17af39 into sindrets:main May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants