Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade babel loader into esbuild loader #374

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bfoong-equinix
Copy link

Upgraded webpack's babel-loader into esbuild-loader to improve transpilation speed

Performance gain reference https://github.com/esbuild-kit/esbuild-loader/discussions/138

@changeset-bot
Copy link

changeset-bot bot commented Mar 29, 2023

🦋 Changeset detected

Latest commit: 42c0417

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
webpack-config-single-spa Patch
webpack-config-single-spa-react Patch
webpack-config-single-spa-ts Patch
webpack-config-single-spa-react-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bfoong-equinix
Copy link
Author

@joeldenning noticed you mentioned in another PR you are not actively maintaining anymore, which maintainer should we ping to get a review?

@gregorysl
Copy link

Looking through other closed PR's, I think @TheMcMurder might be the guy

@bfoong-equinix
Copy link
Author

thanks @gregorysl. @TheMcMurder are you able to review this PR?

@MilanKovacic
Copy link
Collaborator

Hi, this PR would require more work, specifically taking into account caveats mentioned in the esbuild-loader documentation:

Caveats
esbuild only supports a subset of tsconfig options (see TransformOptions interface).

Enable isolatedModules to avoid mis-compilation with features like re-exporting types.

Enable esModuleInterop to make TypeScript's type system compatible with ESM imports.

Features that require type interpretation, such as emitDecoratorMetadata and declaration, are not supported.

→ Read more about TypeScript Caveats

I would recommend starting a discussion in the Slack's maintainers channel so we can discuss the implications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants