Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ForkTsCheckerWebpackPlugin requires build:true #376

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stoopkidddd
Copy link

According to the documentation for fork-ts-checker-webpack-plugin, when you set mode: 'write-references, it is required to also set build: true.

See here - https://github.com/TypeStrong/fork-ts-checker-webpack-plugin#typescript-options

I encountered when working in a monorepo with a single-spa application that imports a single-spa utility. I realized that if you are running webpack locally for both, the TS checker does not recompile and you will get incorrect/out of date errors when you change the contract of a function.

@changeset-bot
Copy link

changeset-bot bot commented Apr 8, 2023

🦋 Changeset detected

Latest commit: 04d46de

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
webpack-config-single-spa-ts Minor
webpack-config-single-spa-react-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@anthonysessa
Copy link

I had this commit open that was meant to solve this issue but it is now out of sync. I am going to close it: #364

cc @filoxo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants