Update webpack-cli to 4.10 #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9e99f85 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
TheMcMurder
reviewed
Jun 10, 2023
TheMcMurder
approved these changes
Jun 10, 2023
robmosca
force-pushed
the
update-webpack-cli
branch
from
b1b602d
to
c0f2798
Compare
robmosca
force-pushed
the
update-webpack-cli
branch
from
c0f2798
to
9e99f85
Compare
robmosca
commented
Jun 11, 2023
| @@ -30,6 +30,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@babel/core": "^7.15.0", | |||
| "@babel/eslint-parser": "^7.15.0", | |||
There was a problem hiding this comment.
This is required here:
I guess this was working before due to the different way the old version of pnpm was hoisting packages...? 🤷🏽♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the problem described in issue #382
NOTE: When running the GitHub actions I had problems with the test step. The problem was that I was using a different version of pnpm on my local. I downgraded to the version previously used in the GitHub actions and could reproduce the problem. With that version of pnpm (6.29.1) my lock file was unstable and it changed when running tests. Also, the tests kept failing. By upgrading pnpm to the latest version (8.6.1) the tests run fine. Due to the update, I had to slightly adjust the commands in the GitHub workflow and add a dev dependency that was missing in the single-spa-welcome app. With these minor changes and adjustments, the GitHub actions workflow runs successfully in my local.