Ian's feedback

.eslintrc

@@ -2,7 +2,7 @@
   "extends": ["important-stuff"],
   "parser": "@typescript-eslint/parser",
   "parserOptions": {
-    "lib": ["dom", "es5", "es2020"]
+    "project": "./tsconfig.json"
   },
   "env": {
     "browser": true,

src/applications/app.helpers.ts

@@ -2,6 +2,7 @@ import {
   ActivityFn,
   AppOrParcel,
   CustomProps,
+  InternalParcel,
   LoadApp,
   ParcelMap,
 } from "../lifecycles/lifecycle.helpers";
@@ -54,8 +55,10 @@ export function toName(app) {
   return app.name;
 }
 
-export function isParcel(appOrParcel) {
-  return Boolean(appOrParcel.unmountThisParcel);
+export function isParcel(
+  appOrParcel: AppOrParcel
+): appOrParcel is InternalParcel {
+  return Boolean((appOrParcel as InternalParcel).unmountThisParcel);
 }
 
 export function objectType(appOrParcel: AppOrParcel): "parcel" | "application" {

src/lifecycles/prop.helpers.ts

@@ -2,7 +2,7 @@ import * as singleSpa from "../single-spa";
 import { mountParcel } from "../parcels/mount-parcel";
 import { isParcel, toName } from "../applications/app.helpers";
 import { formatErrorMessage } from "../applications/app-errors";
-import { AppOrParcel, InternalParcel } from "./lifecycle.helpers";
+import { AppOrParcel, CustomProps, InternalParcel } from "./lifecycle.helpers";
 
 interface SingleSpaProps {
   name: string;
@@ -11,7 +11,9 @@ interface SingleSpaProps {
   unmountSelf(): Promise<AppOrParcel>;
 }
 
-export function getProps(appOrParcel: AppOrParcel): SingleSpaProps {
+export function getProps(
+  appOrParcel: AppOrParcel
+): SingleSpaProps & CustomProps {
   const name = toName(appOrParcel);
   let customProps =
     typeof appOrParcel.customProps === "function"
@@ -40,7 +42,7 @@ export function getProps(appOrParcel: AppOrParcel): SingleSpaProps {
   });
 
   if (isParcel(appOrParcel)) {
-    result.unmountSelf = (appOrParcel as InternalParcel).unmountThisParcel;
+    result.unmountSelf = appOrParcel.unmountThisParcel;
   }
 
   return result;

tsconfig.json

@@ -1,6 +1,11 @@
 {
   "files": ["src/single-spa.ts"],
-  "include": ["src/declarations.d.ts", "src/window-globals.d.ts"],
+  "include": [
+    "src/declarations.d.ts",
+    "src/window-globals.d.ts",
+    "src/devtools/profiler-api.ts",
+    "src/single-spa.profile.ts"
+  ],
   "compilerOptions": {
     "outDir": "typings",
     "emitDeclarationOnly": true,