-
-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop IE11 support. Resolves #1185 #1216
base: 7.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
"last 10 Firefox major versions", | ||
"last 4 Edge major versions" | ||
">5%", | ||
"not ie <= 11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might just be better as not ie
.
@@ -4,7 +4,10 @@ | |||
"@babel/preset-env", | |||
{ | |||
"modules": false, | |||
"bugfixes": true | |||
"bugfixes": true, | |||
"targets": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to specify targets since Babel integrates with browserslist. Setting targets overrides the browserslist configuration.
@@ -116,11 +116,8 @@ | |||
"typescript": "^5.3.3" | |||
}, | |||
"browserslist": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should leave the browserlist defaults, and configure a production/development split.
{
"browserslist": {
"production": [
"defaults"
],
"development": [
"last 2 Chrome versions",
"last 2 Firefox versions",
"last 2 Safari versions"
]
}
}
See #1185