Fail when a timer is not available in the context #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes FakeTimers stricter by failing when trying to fake a timer or object that is not present on the (chosen) global object. To make transitioning easier, we provide a flag to revert to the behavior where missing timers were (mostly) ignored.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #491 +/- ##
=======================================
Coverage 97.50% 97.50%
=======================================
Files 16 16
Lines 3960 3968 +8
=======================================
+ Hits 3861 3869 +8
Misses 99 99
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
fix #490
This makes FakeTimers stricter by failing when trying to fake
a timer or object that is not present on the (chosen) global object.
To make transitioning easier, we provide a flag to revert to the
behavior where missing timers were (mostly) ignored.
Background (Problem in detail) - optional
See #490