This repository has been archived by the owner on Jan 6, 2021. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Fixed linting errors. -Added myself to the authors list.
Pull Request Test Coverage Report for Build 103
💛 - Coveralls |
mantoni
reviewed
Mar 1, 2019
mantoni
approved these changes
Mar 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
Released in |
Very nice! |
Ahh it looks like this change is triggering failures on engines that don't support I noticed this because our project uses PhantomJS for our tests, but IE11 support would also be an issue. |
Thank you for letting us know @bhousel! We will run into the same issue with the Sinon test suite. I didn't think of IE 11 when reviewing. I'll prepare a patch. |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
Properly format JavaScript symbols. Related to sinon#1974.
How to verify - mandatory
npm install
npm test
. This PR adds a symbolic key to one of the objects in a unit test and verifies that it is rendered properly.Checklist for author
npm run lint
passes