Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sinon 9.1 #96

Merged
merged 5 commits into from Oct 1, 2020
Merged

Sinon 9.1 #96

merged 5 commits into from Oct 1, 2020

Conversation

mantoni
Copy link
Member

@mantoni mantoni commented Sep 29, 2020

Purpose (TL;DR) - mandatory

Since sinonjs/sinon#2294 was merged and sinon v9.1.0 released, this adds the new calledOnceWithMatch assertion.

How to verify - mandatory

  1. Check out this branch
  2. npm install
  3. npm test

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

@sinon/samsam was in the tree twice and npm dedupe didn't resolve it.
With `rm -rf node_modules && npm install` the duplication is gone.
@mantoni mantoni added the semver:minor changes will cause a new minor version label Sep 29, 2020
@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #96 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #96   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          113       116    +3     
=========================================
+ Hits           113       116    +3     
Flag Coverage Δ
#unit 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/referee-sinon.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80e966e...51ddec9. Read the comment docs.

@mantoni mantoni merged commit 160b5bf into master Oct 1, 2020
@mantoni mantoni deleted the sinon-9.1 branch October 1, 2020 16:47
@mantoni
Copy link
Member Author

mantoni commented Oct 1, 2020

Released in v7.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor changes will cause a new minor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants