[WIP] Handle cyclic objects

[scripter-co]

Purpose (TL;DR) - mandatory

Resolves issue #1709 by adding @sinonjs/samsam. Removed old dependency and updated references.

[mroderick]

Nice work!

I've added a PR to your PR with a refactoring of deepEqual.

---

However, the matcher still doesn't handle cyclic input.

The way I see it, the matcher part of deepEqual really doesn't belong in deepEqual. It should be in match.js. Further, deepEqual.use should be move to match.js.

That still won't fix the problem.

I think what we need to do is:

• let deepEqual worry about strict comparisons, not loose comparisons
  • move the matcher specific code from deepEqual into match.js
  • move deepEqual.use into match.js
• update match.js to be able to handle circular objects

Perhaps the update to match.js can do what samsam does, or maybe we can extract a function for traversal of potentially circular structures and re-use it

What do you think?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[mroderick]

This has been replaced with #1853