Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export Sinon as an ES module #1809

Merged
merged 15 commits into from
May 29, 2018
Merged

Export Sinon as an ES module #1809

merged 15 commits into from
May 29, 2018

Commits on May 25, 2018

  1. Initial attempt at fixing sinonjs#1805 

    See sinonjs#1805

Not functional bundle. Gets this error:

$ node -r esm -e 'import sinon from ./bundle-esm'
file:///home/carlerik/dev/sinon/bundle-esm.js:1
import typeDetect from 'type-detect';

SyntaxError: Missing export 'default' in ES module: file:///home/carlerik/dev/sinon/node_modules/diff/lib/index.js
    at Object.<anonymous> (file:///home/carlerik/dev/sinon/bundle-esm.js:1)
    @fatso83
    fatso83 committed May 25, 2018
    Configuration menu
    Copy the full SHA
    845a2b8 View commit details
    Browse the repository at this point in the history

  2. Make workable bundle

    @fatso83
    fatso83 committed May 25, 2018
    Configuration menu
    Copy the full SHA
    ce52516 View commit details
    Browse the repository at this point in the history

  3. Add the 'module' keyword for recognition in Rollup and other ESM bund… 

    …lers

fixes sinonjs#1805
    @fatso83
    fatso83 committed May 25, 2018
    Configuration menu
    Copy the full SHA
    0ec297d View commit details
    Browse the repository at this point in the history

  4. Add sourcemapping

    @fatso83
    fatso83 committed May 25, 2018
    Configuration menu
    Copy the full SHA
    17f1b05 View commit details
    Browse the repository at this point in the history

  5. Fix module format 

    Worked accidentally?
    @fatso83
    fatso83 committed May 25, 2018
    Configuration menu
    Copy the full SHA
    5dc2669 View commit details
    Browse the repository at this point in the history

  6. Move rollup into dev

    @fatso83
    fatso83 committed May 25, 2018
    Configuration menu
    Copy the full SHA
    9e4705d View commit details
    Browse the repository at this point in the history

  7. Remove warning on OS module

    @fatso83
    fatso83 committed May 25, 2018
    Configuration menu
    Copy the full SHA
    825d5b5 View commit details
    Browse the repository at this point in the history

  8. Remove comments

    @fatso83
    fatso83 committed May 25, 2018
    Configuration menu
    Copy the full SHA
    c06c8e6 View commit details
    Browse the repository at this point in the history

  9. Rename file

    @fatso83
    fatso83 committed May 25, 2018
    Configuration menu
    Copy the full SHA
    eb86d80 View commit details
    Browse the repository at this point in the history

  10. Fix problem of missing Node global 'process'

    @fatso83
    fatso83 committed May 25, 2018
    Configuration menu
    Copy the full SHA
    e3d9fd2 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2018

  1. Post-build hook that tests the built ECMAScript Module 

    closes sinonjs#1805
    @fatso83
    fatso83 committed May 28, 2018
    Configuration menu
    Copy the full SHA
    19705f8 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2018

  1. Only run *-test.js files in testrunners

    @fatso83
    fatso83 committed May 29, 2018
    Configuration menu
    Copy the full SHA
    8b8b359 View commit details
    Browse the repository at this point in the history

  2. Remove explicit lint-markdown 

    Already included in the 'lint' script. No need to run twice.
    @fatso83
    fatso83 committed May 29, 2018
    Configuration menu
    Copy the full SHA
    1b48934 View commit details
    Browse the repository at this point in the history

  3. Test the esm bundle on Travis 

    https://github.com/GoogleChrome/puppeteer/blob/master/docs/troubleshooting.md#running-puppeteer-on-travis-ci
    @fatso83
    fatso83 committed May 29, 2018
    Configuration menu
    Copy the full SHA
    3646201 View commit details
    Browse the repository at this point in the history

  4. Added some diagnostic output on failure

    @fatso83
    fatso83 committed May 29, 2018
    Configuration menu
    Copy the full SHA
    89dba09 View commit details
    Browse the repository at this point in the history