Restore sinon.createStubInstance() behaviour

lib/sinon/sandbox.js

@@ -51,11 +51,18 @@ function Sandbox() {
         return fakeRestorers;
     };
 
-    sandbox.createStubInstance = function createStubInstance(constructor) {
-        if (typeof constructor !== "function") {
-            throw new TypeError("The constructor should be a function.");
-        }
-        return this.stub(Object.create(constructor.prototype));
+    sandbox.createStubInstance = function createStubInstance() {
+        var stubbed = sinonStub.createStubInstance.apply(null, arguments);
+
+        var ownMethods = collectOwnMethods(stubbed);
+
+        forEach(ownMethods, function(method) {
+            push(collection, method);
+        });
+
+        usePromiseLibrary(promiseLib, ownMethods);
+
+        return stubbed;
     };
 
     sandbox.inject = function inject(obj) {

test/issues/issues-test.js

@@ -657,4 +657,27 @@ describe("issues", function() {
             });
         });
     });
+
+    describe("#2073 - sinon.createStubInstance()", function() {
+        function Foo() {
+            return;
+        }
+        Foo.prototype.testMethod = function() {
+            return 1;
+        };
+
+        it("should override the method", function() {
+            var thing = sinon.createStubInstance(Foo, {
+                testMethod: sinon.stub().returns(2)
+            });
+            assert.equals(thing.testMethod(), 2);
+        });
+
+        it("should support calling without object binding", function() {
+            var createStubInstance = sinon.createStubInstance;
+            refute.exception(function() {
+                createStubInstance(Foo);
+            });
+        });
+    });
 });

test/sandbox-test.js

@@ -280,6 +280,71 @@ describe("Sandbox", function() {
                 });
             }
         });
+
+        it("allows providing optional overrides", function() {
+            var Class = function() {
+                return;
+            };
+            Class.prototype.method = function() {
+                return;
+            };
+
+            var stub = this.sandbox.createStubInstance(Class, {
+                method: sinonStub().returns(3)
+            });
+
+            assert.equals(3, stub.method());
+        });
+
+        it("allows providing optional returned values", function() {
+            var Class = function() {
+                return;
+            };
+            Class.prototype.method = function() {
+                return;
+            };
+
+            var stub = this.sandbox.createStubInstance(Class, {
+                method: 3
+            });
+
+            assert.equals(3, stub.method());
+        });
+
+        it("allows providing null as a return value", function() {
+            var Class = function() {
+                return;
+            };
+            Class.prototype.method = function() {
+                return;
+            };
+
+            var stub = this.sandbox.createStubInstance(Class, {
+                method: null
+            });
+
+            assert.equals(null, stub.method());
+        });
+
+        it("throws an exception when trying to override non-existing property", function() {
+            var Class = function() {
+                return;
+            };
+            Class.prototype.method = function() {
+                return;
+            };
+
+            var sandbox = this.sandbox;
+
+            assert.exception(
+                function() {
+                    sandbox.createStubInstance(Class, {
+                        foo: sinonStub().returns(3)
+                    });
+                },
+                { message: "Cannot stub foo. Property does not exist!" }
+            );
+        });
     });
 
     describe(".stub", function() {