Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mochify from 6.3.0 to 6.4.1 #2109

Closed

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Oct 1, 2019

Bumps mochify from 6.3.0 to 6.4.1.

Changelog

Sourced from mochify's changelog.

6.4.1

  • 馃悰 28de861
    Fix SSL certificate warning filter

Released by Maximilian Antoni on 2019-08-09.

6.4.0

  • 馃崗 ff7decb
    Prevent resources from logging errors
    • Swallow SSL certificate warning on https page load
    • Handle image, font and stylesheet requests to prevent warnings
  • 馃崗 3f96b8c
    Upgrade puppeteer to v1.19.0
  • 馃悰 e663ea8
    Make chromium tests less flaky
    • Use a random port in https-server tests.
    • Wait for server.close to finish.
  • 馃洝 abebbf3
    npm audit
  • 馃洝 34a3392
    Bump lodash from 4.17.11 to 4.17.14 (#204) (dependabot[bot])

    Bumps lodash from 4.17.11 to 4.17.14.
    >

>
> Signed-off-by: dependabot[bot] <support@github.com>

Released by Maximilian Antoni on 2019-08-09.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Oct 1, 2019
@fearphage
Copy link
Member

@mantoni You know what broke in mochify? Nothing in the changelog is jumping out at me.

@mantoni
Copy link
Member

mantoni commented Oct 2, 2019

I preproduced locally and narrowed it down to this puppeteer issue. When I remove the request interception, it works fine again. The issue seems stale, so I'm not sure how to continue here. I could introduce yet another command line option to work around it, but that doesn't feel right.

Background: The request interseption was introduced to ignore image, font, media and stylesheet requests. If you're testing web page components that load these resources it causes a lot of noise in the output due to failing requests.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/mochify-6.4.1 branch from 5b33db4 to e0cb204 Compare October 2, 2019 07:11
Bumps [mochify](https://github.com/mantoni/mochify.js) from 6.3.0 to 6.4.1.
- [Release notes](https://github.com/mantoni/mochify.js/releases)
- [Changelog](https://github.com/mantoni/mochify.js/blob/master/CHANGES.md)
- [Commits](mantoni/mochify.js@v6.3.0...v6.4.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/mochify-6.4.1 branch from e0cb204 to d79f5c7 Compare October 2, 2019 07:17
@mantoni
Copy link
Member

mantoni commented Oct 5, 2019

I've introduced a new flag in mochify to work around this issue. I'll close this PR and do the upgrade myself including the new flag for the web worker test script.

@mantoni mantoni closed this Oct 5, 2019
@dependabot-preview
Copy link
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@mantoni mantoni deleted the dependabot/npm_and_yarn/mochify-6.4.1 branch October 5, 2019 08:48
mantoni added a commit that referenced this pull request Oct 5, 2019
This upgrades Mochify to the latest version and works around an issue in
Puppeteer where the web worker request isn't handled properly if request
interception is turned on.

See #2109
mroderick pushed a commit that referenced this pull request Oct 5, 2019
This upgrades Mochify to the latest version and works around an issue in
Puppeteer where the web worker request isn't handled properly if request
interception is turned on.

See #2109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants