Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fixes only - using more explicit assertions #2221

Merged
merged 1 commit into from Feb 18, 2020

Conversation

fearphage
Copy link
Member

This fixes tests created in #2150. This contains a few fixes from that branch and some others I found while grepping.

Copy link
Member

@mantoni mantoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mantoni mantoni merged commit 7498f1a into sinonjs:master Feb 18, 2020
@fearphage fearphage deleted the test-fixes branch February 18, 2020 13:17
@mroderick
Copy link
Member

Did anyone push a new release to npm with the changes from #2150?

@mantoni
Copy link
Member

mantoni commented Feb 18, 2020

No, sorry. I didn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants