Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy over acessor properties to target object #2387 #2391

Merged
merged 1 commit into from Jul 27, 2021

Conversation

sauravazad
Copy link
Contributor

@sauravazad sauravazad commented Jul 17, 2021

Fix for issue #2387 where acessor properties were not copied over to target object

The existing implementation assumed that all the properties of an object are Data property
Documentation link : https://developer.mozilla.org/en-US/docs/Web/JavaScript/Data_structures#properties

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

@codecov
Copy link

codecov bot commented Jul 17, 2021

Codecov Report

Merging #2391 (258caee) into master (57c6c63) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2391      +/-   ##
==========================================
+ Coverage   96.07%   96.08%   +0.01%     
==========================================
  Files          41       41              
  Lines        1883     1891       +8     
==========================================
+ Hits         1809     1817       +8     
  Misses         74       74              
Flag Coverage Δ
unit 96.08% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/sinon/util/core/extend.js 97.87% <100.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57c6c63...258caee. Read the comment docs.

@sauravazad sauravazad marked this pull request as ready for review July 17, 2021 14:59
@mroderick mroderick added the semver:patch changes will cause a new patch version label Jul 27, 2021
@mroderick
Copy link
Member

Thank you for the pull request and the thorough investigation of this issue 💯

@mroderick mroderick merged commit 08e9536 into sinonjs:master Jul 27, 2021
@mroderick
Copy link
Member

This has been published to the npm registry as sinon@11.1.2

@sauravazad sauravazad deleted the acessorProperties branch July 27, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch changes will cause a new patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants