Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make calledWith() assertions idempotent #2407

Merged
merged 2 commits into from Nov 3, 2021
Merged

Make calledWith() assertions idempotent #2407

merged 2 commits into from Nov 3, 2021

Commits on Nov 2, 2021

  1. Add failing test for idempotent calledWith

    @cincodenada
    cincodenada committed Nov 2, 2021
    Copy the full SHA
    3fbfad5 View commit details
    Browse the repository at this point in the history

  2. Make calledWith() assertions idempotent 

    Previously, calledWith() modified the list of arguments (called and
expected) in place, so that repeated calls to calledWith() assertions
ended up being repeatedly escaped.

This fixes that behavior, copying the arguments out of the spy's
internal array before modifying them.
    @cincodenada
    cincodenada committed Nov 2, 2021
    Copy the full SHA
    babd5c3 View commit details
    Browse the repository at this point in the history