Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up remaining merge issues from #2426 #2434

Merged
merged 1 commit into from Jan 28, 2022

Conversation

cincodenada
Copy link
Contributor

@cincodenada cincodenada commented Jan 28, 2022

Purpose (TL;DR)

Fix npm releases after a test commit slipped in in #2426

Background (Problem in detail) - optional

This was left in place from the releases switchover, it was intended to
be removed before merging but I failed to communicate that adequately,
so it slipped in.

That commit also removed the post-build script, but that has since been
added back in already.

How to verify - mandatory

The only way to actually verify this, by its nature, is to run a release. It's a pretty simple change though.

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

This was left in place from the releases switchover, it was intended to
be removed before merging but I failed to communicate that adequately,
so it slipped in.

That commit also removed the post-build script, but that has since been
added back in already.
@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #2434 (3517fac) into master (4aa9a9e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2434   +/-   ##
=======================================
  Coverage   96.01%   96.01%           
=======================================
  Files          41       41           
  Lines        1906     1906           
=======================================
  Hits         1830     1830           
  Misses         76       76           
Flag Coverage Δ
unit 96.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aa9a9e...3517fac. Read the comment docs.

@cincodenada cincodenada changed the title Remove dry-run flag from npm publish Fix up remaining merge issues from #2426 Jan 28, 2022
@fatso83 fatso83 merged commit a57bbf6 into sinonjs:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants