Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.define method #2539

Merged
merged 10 commits into from
Sep 11, 2023
Merged

.define method #2539

merged 10 commits into from
Sep 11, 2023

Commits on Aug 11, 2023

  1. Restore sandbox after each .replace test 

    Otherwise a failed test may not restore it.
    @gukoff
    gukoff committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    494e437 View commit details
    Browse the repository at this point in the history

  2. .define method for temporarily defining new properties during the tests

    @gukoff
    gukoff committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    9e1e7a2 View commit details
    Browse the repository at this point in the history

  3. better comment

    @gukoff
    gukoff committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    de4a6b1 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. detailed exception messages

    @gukoff
    gukoff committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    6f3f063 View commit details
    Browse the repository at this point in the history

  2. properly delete the property during the cleanup

    @gukoff
    gukoff committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    d0cb6ba View commit details
    Browse the repository at this point in the history

  3. Add .define to more places

    @gukoff
    gukoff committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    0f37f63 View commit details
    Browse the repository at this point in the history

  4. Document .define

    @gukoff
    gukoff committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    747bd96 View commit details
    Browse the repository at this point in the history

  5. Fix test

    @gukoff
    gukoff committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    eecb5a7 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. Code review suggestions

    @gukoff
    gukoff committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    eab4560 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. prettier --write

    @gukoff
    gukoff committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    d8d7d15 View commit details
    Browse the repository at this point in the history