Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #2589: avoid invoking getter as side-effect #2592

Merged
merged 1 commit into from Apr 25, 2024
Merged

fix #2589: avoid invoking getter as side-effect #2592

merged 1 commit into from Apr 25, 2024

Commits on Apr 25, 2024

  1. fix #2589: avoid invoking getter as side-effect 

    of creating restorerer function. Check for the odd case
where we actually force setting a value through accessor
functions and only look up the value at that time.

The alternative would be more elaborate, check if the
descriptor had a `get` or a `value` field, and then
decide, but this should do the trick.
    @fatso83
    fatso83 committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    415a87c View commit details
    Browse the repository at this point in the history