Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimist from 1.1.1 to 1.2.3 #402

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Apr 4, 2020

Bumps minimist from 1.1.1 to 1.2.3.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 4, 2020
@CoreyKovalik
Copy link

Can this get merged? Thanks

GHSA-vh95-rmgr-6w4m

@sintaxi
Copy link
Owner

sintaxi commented May 17, 2020

This has been addressed in another branch and will be included in the next release of surge (very soon).

eb82735

@jfarmer
Copy link

jfarmer commented Jun 6, 2020

I use surge w/ students (~50 every semester) and it's rough having security warnings or other "just ignore it" output over the course of recommended usage. For example, if they follow the instructions on the site, the output looks different than what the site suggests and they spin their wheels thinking they did something wrong.

Between this and #403 I'm looking for alternatives. Hopefully, a new version is released before then!

@sintaxi
Copy link
Owner

sintaxi commented Jun 7, 2020

@jfarmer I'll see what I can do about cutting a patch release for you. When do you need this by?

@jfarmer
Copy link

jfarmer commented Jun 7, 2020

@sintaxi We have another group of students starting July 6th, so before then would be great. Appreciate it!

I realize that #403 is out of your hands, short of monkey-patching (ew!).

@sintaxi
Copy link
Owner

sintaxi commented Jun 7, 2020

@jfarmer Ok! I'll have a release for you.

Yeah, not sure about #403 but I'll look into it.

Bumps [minimist](https://github.com/substack/minimist) from 1.1.1 to 1.2.3.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.1.1...1.2.3)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/minimist-1.2.3 branch from 1df5033 to 9603183 Compare July 6, 2020 08:55
@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Jul 6, 2020

Looks like minimist is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Jul 6, 2020
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/minimist-1.2.3 branch July 6, 2020 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants