Allow running the unit tests on more recent PHPUnit versions #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've tested and the unit tests as-is are compatible with PHPUnit 7.x and 8.x without needing any adjustments, so we may as well allow using/installing those versions. Includes widening the version requirements for the `limedeck/phpunit-detailed-printer` to prevent it from being a blocker for using more recent PHPUnit versions. Version 4.x of the `limedeck/phpunit-detailed-printer` is compatible with PHPUnit 7.x, version 5.x is compatible with PHPUnit 8.x. Ref: https://github.com/LimeDeck/phpunit-detailed-printer/releases
|
Good idea. Are there images of php 8 already? Maybe we should also edit |
|
Oh, I mis-read this. phpUNIT. Yes. Of course. |
|
On Travis I know you can already run against Either way, I know that DealerDirect Composer PHPCS plugin will currently not (yet) install on PHP 8, so that would block testing. |
sirbrillig
pushed a commit
that referenced
this pull request
May 25, 2020
I've tested and the unit tests as-is are compatible with PHPUnit 7.x and 8.x without needing any adjustments, so we may as well allow using/installing those versions. Includes widening the version requirements for the `limedeck/phpunit-detailed-printer` to prevent it from being a blocker for using more recent PHPUnit versions. Version 4.x of the `limedeck/phpunit-detailed-printer` is compatible with PHPUnit 7.x, version 5.x is compatible with PHPUnit 8.x. Ref: https://github.com/LimeDeck/phpunit-detailed-printer/releases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested and the unit tests as-is are compatible with PHPUnit 7.x and 8.x without needing any adjustments, so we may as well allow using/installing those versions.
Includes widening the version requirements for the
limedeck/phpunit-detailed-printerto prevent it from being a blocker for using more recent PHPUnit versions.Version 4.x of the
limedeck/phpunit-detailed-printeris compatible with PHPUnit 7.x, version 5.x is compatible with PHPUnit 8.x.Ref: https://github.com/LimeDeck/phpunit-detailed-printer/releases