Add custom color for seeker #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I've been using this package well lately.
Thank you for sharing the wonderful package.
The color of the seeker is basically red right now, but I thought it would be nice if I could customize this, so I changed some code. It works like this:
If you specify seekerColor in config, the color of Timeline and Seeker is changed.
You can merge if you feel it's a good idea.
PS. I tested the code by modifying node_module code directly in my RN project. I also wanted to do separate build test but I couldn't because of some version errors. I think it's just my local env problem, because there are only code changes for logic, not for package dependencies. If you want to merge, I think you need a test before publish it.