Add support for the logger private buffer pool. #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
link #1247 |
dgsb
requested changes
Apr 22, 2021
| @@ -260,6 +261,13 @@ func (entry *Entry) log(level Level, msg string) { | |||
| } | |||
| } | |||
|
|
|||
| func (entry *Entry) getBufferPool() (pool BufferPool) { | |||
| if entry.Logger.BufferPool != nil { | |||
There was a problem hiding this comment.
Can we have that protected by the logger mutex ?
There was a problem hiding this comment.
The only place to call this method is already protected by a mutex.
dgsb
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a private buffer pool for the logger. By default, the default global buffer pool will be used.