Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add go 1.17 to test matrix #1277

Merged
merged 2 commits into from Sep 12, 2021
Merged

ci: add go 1.17 to test matrix #1277

merged 2 commits into from Sep 12, 2021

Conversation

anajavi
Copy link
Contributor

@anajavi anajavi commented Sep 2, 2021

Adds go 1.17 to github actions test matrix.

@@ -47,7 +47,7 @@ jobs:
timeout-minutes: 10
strategy:
matrix:
go-version: [1.14.x, 1.15.x, 1.16.x]
go-version: [1.14.x, 1.15.x, 1.16.x, 1.17.x]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove all former version and only keep 1.17.x in order to speed up CI runs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@dgsb
Copy link
Collaborator

dgsb commented Sep 11, 2021

Thanks @anajavi, can update your PR according to my review ?

@anajavi
Copy link
Contributor Author

anajavi commented Sep 12, 2021

Thanks @anajavi, can update your PR according to my review ?

I've updated the PR.

@dgsb dgsb merged commit accc7da into sirupsen:master Sep 12, 2021
@anajavi anajavi deleted the patch-1 branch September 12, 2021 08:22
@anajavi anajavi restored the patch-1 branch September 12, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants