New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testutils: fix testify usage (report by testifylint) #1424

Open

dolmen wants to merge 1 commit into sirupsen:master from dolmen:fix-testutils-testifylint

Contributor

dolmen commented Mar 12, 2024

Use require.NoError(t, err) instead of require.Nil(t, err) as suggested by testifylint.

$ golangci-lint version
golangci-lint has version 1.56.2 built with go1.22.0 from 58a724a on 2024-02-15T12:52:06Z
$ golangci-lint run ./internal/testutils
internal/testutils/testutils.go:26:2: error-nil: use require.NoError (testifylint)
	require.Nil(t, err)
	^


          testutils: fix testify usage (report by testifylint)

294b497

Use require.NoError(t, err) instead of require.Nil(t, err).

dolmen mentioned this pull request

CI: upgrade golangci-lint to v1.56 #1425

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment