Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/app-rail-enhancement #1727

Merged
merged 4 commits into from
Jul 14, 2023

Conversation

Mahmoud-zino
Copy link
Contributor

Linked Issue

Closes #1722

Description

Added size props to tiles/anchors for more control over the size.
Added aspectRatio prop to control the aspectRatio.

Changsets

feat: AppRail tiles & anchors providing more controls over size and aspect ratio.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
andir Andreas Rammhold
…/anchors
@changeset-bot
Copy link

changeset-bot bot commented Jul 5, 2023

🦋 Changeset detected

Latest commit: 125e7f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@skeletonlabs/skeleton Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Jul 14, 2023 8:09pm

@Mahmoud-zino
Copy link
Contributor Author

@endigo9740 sorry, I created the issue as a bug but it was just an enhancement 😉.

@endigo9740
Copy link
Contributor

No worries, I've adjusted it for you @Mahmoud-zino

@endigo9740
Copy link
Contributor

endigo9740 commented Jul 14, 2023

Just documenting that we dropped the width property on the children tiles in favor of reworking the styling for the App Rail. If you want a "gap" surrounding each tile, then use the style props for the lead/default/trail slots in the App Rail, we suggest implementing a padding like so: regionDefault="p-4". The tile styles have now been updated to automatically resize to account for the offset width.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppRailAnchor: can't resize anchors using class override
2 participants