Bugfix/autocomplete-allowed-options

[Mahmoud-zino]

Linked Issue

Closes #1723

Description

After filtering the list by allowedList, It's value will reset by the denyList logic only if the denyList is empty.

Solution

Checking for both allowedList and DenyList before resetting the list will solve the issue without side effects.

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages/skeleton, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

bugfix: Autocomplete allowedlist.

Please read and apply all contribution requirements.

• This PR targets the dev branch (NEVER master)
• Documentation reflects all relevant changes
• Branch is prefixed with: docs/, feat/, chore/, bugfix/
• Ensure Svelte and Typescript linting is current - run pnpm check
• Ensure Prettier linting is current - run pnpm format
• All test cases are passing - run pnpm test
• Includes a changeset (if relevant; see above)

[changeset-bot]

🦋 Changeset detected

Latest commit: 4cdb7de

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@skeletonlabs/skeleton	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
skeleton-docs	✅ Ready (Inspect)	Visit Preview	Jul 13, 2023 10:32pm

[AdrianGonz97]

I added some adjustments to how the filtering for allow and deny worked to be a bit more efficient.
I also fixed the reactive statement $: if (allowlist || denylist) filterByAllowDeny(); as this will always evaluate to true as arrays are truthy, even empty ones. Switching to allowlist.length || denylist.length fixes this.

The rest is great!

[endigo9740]

Seems to be working great. Thanks for the assist @AdrianGonz97