bugfix: fix a11y warning in Ratings component

[Gerschtli]

Description

Before this fix, the following warning occurred:

A11y: <svelte:element> with click handler must have an ARIA role

This was an issue because the on:click binding was always applied, even when the element would be not interactive (a span).

Checklist

Please read and apply all contribution requirements.

• This PR targets the dev branch (NEVER master)
• Documentation reflects all relevant changes
• Branch is prefixed with: docs/, feat/, chore/, bugfix/
• Ensure Svelte and Typescript linting is current - run pnpm check
• Ensure Prettier linting is current - run pnpm format
• All test cases are passing - run pnpm test
• Includes a changeset (if relevant; see above)

[changeset-bot]

🦋 Changeset detected

Latest commit: f5b63c9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@skeletonlabs/skeleton	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
skeleton-docs	✅ Ready (Inspect)	Visit Preview	Jul 9, 2023 3:47pm

[endigo9740]

@Gerschtli we have an open ticket regarding this:
#1708

We announced this during the last release that we will be investigating each of these to determine how we wish to handle these (bottom of the page):
#1716

But we typically like to keep these kind of sweeping changes uniform - so I'll consider your PR, but cannot promise we'll move forward with it if we decide to go another way. This is especially critical when it affects a11y. There are certain rules and considerations that need to be adhered when touching anything related to accessibility to ensure we get this right.

Thanks for your patience in the meantime.

Also make sure you read our contribution guidelines - we typically ask for folks to volunteer rather than surprise us with PRs. We've ran into several instances of duplicate effort in the past, and we're doing our best to try and avoid that:
https://www.skeleton.dev/docs/contributing

[Gerschtli]

I searched for issues like that, must have slipped through.. No worries, I just saw the warning and it wasn't that complicated to fix. Take your time and feel free to close my PR, if you want to go another route :)

Thank you for building and maintaining this awesome project!

[AdrianGonz97]

@Gerschtli Thanks for the PR! These changes are excellent and are exactly what I had planned to do anyway 😄.

[endigo9740]

It's not as DRY, but I think given the simplicity of the component this will suffice for now. Merging now and this will be a part of next week's release. Thanks for your contribution!