Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/autocomplete-denyallow-lists-reactive-update #1825

Conversation

Mahmoud-zino
Copy link
Contributor

Linked Issue

Closes #1812

Description

see #1812 (comment) and #1812 (comment)

Changsets

bugfix: autocomplete fixed reactive update when allow and deny lists are empty.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
andir Andreas Rammhold
@vercel
Copy link

vercel bot commented Aug 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Aug 5, 2023 4:18pm

@changeset-bot
Copy link

changeset-bot bot commented Aug 5, 2023

🦋 Changeset detected

Latest commit: a80a741

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@skeletonlabs/skeleton Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Mahmoud-zino Mahmoud-zino changed the title fixed allow,deny lists reactive update when empty bugfix/autocomplete-denyallow-lists-reactive-update Aug 5, 2023
@endigo9740 endigo9740 merged commit 12b63fe into skeletonlabs:dev Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete denylist always blocks at least 1 option after being populated and then emptied.
2 participants