feat: add generic parameters to Modal interfaces

[matadaniel]

Description

Improve Modal types

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

• This PR targets the dev branch (NEVER master)
• Documentation reflects all relevant changes
• Branch is prefixed with: docs/, feat/, chore/, bugfix/
• Ensure Svelte and Typescript linting is current - run pnpm ci:check
• Ensure Prettier linting is current - run pnpm format
• All test cases are passing - run pnpm test
• Includes a changeset (if relevant; see above)

[changeset-bot]

⚠️ No Changeset found

Latest commit: 90aff9c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
skeleton-docs	✅ Ready (Inspect)	Visit Preview	May 30, 2024 5:42pm

[vercel]

@matadaniel is attempting to deploy a commit to the Skeleton Labs Team on Vercel.

A member of the Team first needs to authorize it.

[endigo9740]

@AdrianGonz97 @ryceg if you guys get a chance you can please review this one. Thank you!

[ryceg]

Yeah this looks solid- I'll give it a spin but it's quite a minimal change, but will allow for much better DX.

[endigo9740]

@matadaniel Just checking on the status of this one. I noted it's still in a "draft" state, so I wanted to confirm all work is complete. Make sure to bump to "ready for review" when you hit that status.

If @ryceg gives the thumbs up we'll merge right away. Thanks!

[matadaniel]

I made it a draft PR since you said it would allow you to review sooner rather than later, and I wanted a review to make sure no one's current types would break. I have also not completed much of the PR template checklist.

I did come across a discussion that I am unable to find now that mentioned that the ModalSettings.value type should stay as any rather than string. I will add it to the ModalSettings' generic parameters.