Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXT Documentation site: Search #2677

Merged
merged 27 commits into from
May 25, 2024
Merged

Conversation

Hugos68
Copy link
Contributor

@Hugos68 Hugos68 commented May 18, 2024

Linked Issue

Closes #2675

Description

Adds search through Pagefind

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the next branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm ci:check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

Copy link

changeset-bot bot commented May 18, 2024

⚠️ No Changeset found

Latest commit: 9bc24b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
skeleton-docs ⬜️ Ignored (Inspect) Visit Preview May 25, 2024 11:52am

Copy link

vercel bot commented May 18, 2024

@Hugos68 is attempting to deploy a commit to the Skeleton Labs Team on Vercel.

A member of the Team first needs to authorize it.

@Hugos68
Copy link
Contributor Author

Hugos68 commented May 19, 2024

Currently all codeblocks are indexed, this is probably not desirable. We can ignore blocks of HTML by applying the data-pagefind-ignore attribute.

@Hugos68
Copy link
Contributor Author

Hugos68 commented May 19, 2024

We might also should consider adding a recent search list, given you often want to revisit the same doc page often when developing with said component/style

@Hugos68 Hugos68 marked this pull request as ready for review May 21, 2024 20:50
@Hugos68 Hugos68 changed the title Added search NEXT Documentation site: Search feature May 22, 2024
@Hugos68 Hugos68 changed the title NEXT Documentation site: Search feature NEXT Documentation site: Search May 22, 2024
@endigo9740 endigo9740 merged commit d70eef7 into skeletonlabs:next May 25, 2024
2 of 3 checks passed
@Hugos68 Hugos68 deleted the docs/search branch May 26, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants