Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump packages and rewrite webpack config to use webpack 5 #189

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jhbuchanan45
Copy link

  • Upgraded almost all packages to the latest available, and hopefully fixed any breaking changes (Only 'uuid' required changes to the app code to import and use v4 instead of old default export of v1 uuid generator)
  • Uses latest version of GraphiQL ('1.4.2') and GraphQL ('15.5.0')
  • Uses Webpack 5 and Babel 7 with appropriate configs
  • Removed dev dependencies that seem to no longer be used, mostly to do with the old webpack config
  • Added dev dependency "electron": "^11.0.0" to specify version for electron-builder
  • Added npm/yarn run watch command which uses webpack --watch to enable debugging while working faster (replacement for webpack dev server which doesn't currently work with the new config)

Fixes #188, #175 and any others with 'Harfbuzz version too old (1.2.7)' error
Fixes #179 (Not seeing that error anyway on any platforms when building)

I have not tested freshly built installers for mac or win, only on Linux. To resolve these errors, a new version would have to be released with newly built file attached.
I have also written a github workflow for this which uses 'samuelmeuli/action-electron-builder@v1.6.0' to invoke electron-builder inside the native OS for linux/windows/mac builds and automatically drafts a release with the files uploaded (I think it uses electron-builder release under the hood) when 'v*' tags are pushed to the repo

NodeJS v16 currently doesn't work with electron builder, (see electron-userland/electron-builder#5668) use v15 or older to build

@MannySchneck
Copy link

Thank you for this PR!

@kagof
Copy link

kagof commented Mar 4, 2022

Hi @jhbuchanan45 this is really great stuff. I've tried merging your changes into my fork of this app, but I'm running into issues with (I assume) the modal for editing HTTP headers. Any time I try to edit an existing one, or save a new one, the screen goes white, and I have to close/refresh the app which then looses the changes I've made. It happens every time, and using Node 15 as recommended, or Node 17, I am getting the same result.

I'm pretty unfamiliar with using electron so don't really know where to begin with this. Any chance you'd be able to look into it or give me a pointer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants